Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eng 472 component wrap up llm command generator #12873

Merged
merged 18 commits into from
Oct 20, 2023
Merged

Eng 472 component wrap up llm command generator #12873

merged 18 commits into from
Oct 20, 2023
+784 −184

Conversation

djcowley
Copy link
Contributor

Proposed changes:

  • Tidy up doc strings and some variable names.
  • Reorder the main methods of the class for readability. (this has made the diff harder to read unfortunately.)
  • Rename the test folder to match the folder structure in the module code.
  • Add unit tests.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@djcowley djcowley requested a review from a team as a code owner September 26, 2023 10:05
@twerkmeister twerkmeister requested review from twerkmeister and removed request for a team October 4, 2023 13:03
@djcowley djcowley force-pushed the ENG-472-Component-Wrap-up-LLMCommandGenerator branch from 1024d3a to a088531 Compare October 4, 2023 13:37
twerkmeister
twerkmeister reviewed Oct 5, 2023
View reviewed changes
Copy link
Contributor

@twerkmeister twerkmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a number of suggestions around the wrap up that I think would increase code quality in the component. Let me know what you think

rasa/dialogue_understanding/generator/llm_command_generator.py Outdated Show resolved Hide resolved
rasa/dialogue_understanding/generator/llm_command_generator.py Outdated Show resolved Hide resolved
rasa/dialogue_understanding/generator/llm_command_generator.py Outdated Show resolved Hide resolved
rasa/dialogue_understanding/generator/llm_command_generator.py Outdated Show resolved Hide resolved
rasa/dialogue_understanding/generator/llm_command_generator.py Outdated Show resolved Hide resolved
rasa/dialogue_understanding/generator/llm_command_generator.py Outdated Show resolved Hide resolved
rasa/dialogue_understanding/generator/llm_command_generator.py Outdated Show resolved Hide resolved
rasa/dialogue_understanding/generator/llm_command_generator.py Outdated Show resolved Hide resolved
rasa/dialogue_understanding/generator/llm_command_generator.py Outdated Show resolved Hide resolved
rasa/dialogue_understanding/generator/llm_command_generator.py Outdated Show resolved Hide resolved
@djcowley
chore: responded to review comments. adding FlowList.user_flows, upda…
ff6de9f 
…ting FLowList.user_flow_ids, making FlowLists itterable.
twerkmeister
twerkmeister approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@twerkmeister twerkmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really liking where this is going! I think it's looking great and your testing is really thorough.

Approving with 3 small suggestions that I trust you can take care of. If you need more feedback, ping me again :)

rasa/dialogue_understanding/generator/llm_command_generator.py Outdated Show resolved Hide resolved
rasa/dialogue_understanding/generator/llm_command_generator.py Outdated Show resolved Hide resolved
tests/dialogue_understanding/generator/test_llm_command_generator.py Show resolved Hide resolved
@djcowley djcowley merged commit 570c339 into dm2 Oct 20, 2023
99 checks passed
@djcowley djcowley deleted the ENG-472-Component-Wrap-up-LLMCommandGenerator branch October 20, 2023 11:50
@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug C 4 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 54 Code Smells

0.0% 0.0% Coverage
0.8% 0.8% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twerkmeister twerkmeister twerkmeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djcowley @twerkmeister